Re: [HACKERS] Re: datetime regress test busted by incomplete checkin

From: Oleg Broytmann <phd(at)sun(dot)med(dot)ru>
To: "Thomas G(dot) Lockhart" <lockhart(at)alumni(dot)caltech(dot)edu>
Cc: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <hackers(at)postgreSQL(dot)org>
Subject: Re: [HACKERS] Re: datetime regress test busted by incomplete checkin
Date: 1999-01-25 16:10:02
Message-ID: Pine.SOL2.3.96.SK.990125190635.18860B-100000@sun.med.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi!

On Mon, 25 Jan 1999, Thomas G. Lockhart wrote:
> Could you phrase the query in the same style as most of the other tests
> (a style we inherited from the original sources), where the first column
> is a select of an empty string with the table count as the label? I
> would suggest something like:
>
> SELECT '' AS one,
> datetime('1994-01-01', '11:00') AS "Sat Jan 01 11:00:00 1994 PST";

I got my style from the lines above my test. There are things like:

SELECT ('now'::datetime - 'current'::datetime) AS "ZeroSecs";

"Sat Jan 01 11:00:00 1994 PST" looks bad as a result, I think.

Of course, I can recreate the patch, but should I?

Oleg.
----
Oleg Broytmann http://members.tripod.com/~phd2/ phd2(at)earthling(dot)net
Programmers don't die, they just GOSUB without RETURN.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Oleg Broytmann 1999-01-25 16:13:32 Re: [HACKERS] Re: datetime regress test busted by incomplete checkin
Previous Message Bruce Momjian 1999-01-25 16:00:04 Re: [HACKERS] Re: datetime regress test busted by incomplete checkin