Re: [HACKERS] Re: datetime regress test busted by incomplete checkin

From: Oleg Broytmann <phd(at)sun(dot)med(dot)ru>
To: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
Cc: tgl(at)sss(dot)pgh(dot)pa(dot)us, hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] Re: datetime regress test busted by incomplete checkin
Date: 1999-01-25 15:34:26
Message-ID: Pine.SOL2.3.96.SK.990125183232.18860A-100000@sun.med.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi!

On Mon, 25 Jan 1999, Bruce Momjian wrote:
> You need to patch datetime.sql too. That is required to generate the
> proper expected file, which is compared to the out file. Can you supply
> the patch?

But it is here - 20 lines below from the beginning of the patch. The
patch was generated by make_diff tools. Isn't it enough?

> > *** ./src/test/regress/expected/datetime.out.orig Mon Jan 5 06:35:27 1998
> > --- ./src/test/regress/expected/datetime.out Wed Jan 6 12:50:50 1999
> > ***************
> > *** 28,33 ****
> > --- 28,40 ----
> > @ 0
> > (1 row)
> >
> > + QUERY: SET DateStyle = 'Postgres,noneuropean';
> > + QUERY: SELECT datetime('1994-01-01', '11:00') AS "Jan_01_1994_11am";
> > + Jan_01_1994_11am
> > + ----------------------------
> > + Sat Jan 01 11:00:00 1994 PST
> > + (1 row)
> > +
> > QUERY: CREATE TABLE DATETIME_TBL( d1 datetime);
> > QUERY: INSERT INTO DATETIME_TBL VALUES ('current');
> > QUERY: INSERT INTO DATETIME_TBL VALUES ('today');
> > *** ./src/test/regress/sql/datetime.sql.orig Sat Nov 15 05:55:57 1997
> > --- ./src/test/regress/sql/datetime.sql Wed Jan 6 12:49:23 1999
> > ***************
> > *** 10,15 ****
> > --- 10,18 ----
> > SELECT ('current'::datetime = 'now'::datetime) as "True";
> > SELECT ('now'::datetime - 'current'::datetime) AS "ZeroSecs";
> >
> > + SET DateStyle = 'Postgres,noneuropean';
> > + SELECT datetime('1994-01-01', '11:00') AS "Jan_01_1994_11am";
> > +
> > CREATE TABLE DATETIME_TBL( d1 datetime);
> >
> > INSERT INTO DATETIME_TBL VALUES ('current');

Oleg.
----
Oleg Broytmann http://members.tripod.com/~phd2/ phd2(at)earthling(dot)net
Programmers don't die, they just GOSUB without RETURN.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 1999-01-25 15:37:11 Re: [HACKERS] postgres (zombie)
Previous Message Vadim Mikheev 1999-01-25 15:27:12 Re: [HACKERS] Postgres Speed or lack thereof