Re: pgsql: Improve performance of timezone loading, especially pg_timezone_

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Improve performance of timezone loading, especially pg_timezone_
Date: 2017-05-07 14:57:08
Message-ID: 19225.1494169028@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> writes:
> OK, so it looks like GenerateTimezoneFiles in Install.pm for the MSVC
> build does not quite do what make install does for src/timezone.
> Nothing seems to pass the -p parameter as the following is doing:

Ah-hah. Still, the log message should have been there before.
Maybe just nobody noticed?

> The attached also adds the NUL char back to fullname in pg_open_tzfile().

Oooh ... I did not think that was necessary, but on closer inspection
you are right.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Kapila 2017-05-07 14:58:27 Re: pgsql: Improve performance of timezone loading, especially pg_timezone_
Previous Message Michael Paquier 2017-05-07 12:38:05 Re: Change GetLastImportantRecPtr's definition? (wasSkip checkpoints, archiving on idle systems.)