Re: pgsql: Improve performance of timezone loading, especially pg_timezone_

On 7 May 2017 at 21:03, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> wrote:
> Perhaps we just need to put the NUL char back, to trim off the filename again:
>
> /* If that didn't work, fall through to do it the hard way */
> fullname[fullnamelen] = '\0';
>
> but I've not yet looked into why the file is missing in the first place.

OK, so it looks like GenerateTimezoneFiles in Install.pm for the MSVC
build does not quite do what make install does for src/timezone.
Nothing seems to pass the -p parameter as the following is doing:

install: all installdirs
ifeq (,$(with_system_tzdata))
$(ZIC) -d '$(DESTDIR)$(datadir)/timezone' -p '$(POSIXRULES)' $(TZDATAFILES)

I've attached a patch for review. My perl skills are at "trial and
error" level, so please review carefully.

The attached also adds the NUL char back to fullname in pg_open_tzfile().

--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services