Re: pgsql: Improve performance of timezone loading, especially pg_timezone_

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Improve performance of timezone loading, especially pg_timezone_
Date: 2017-05-07 15:03:36
Message-ID: CAA4eK1+0aGUxx9WfNzXiRE=0SVTr2vAxGh0+WfB8cxYeyPwaQA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Sun, May 7, 2017 at 8:27 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> writes:
>> OK, so it looks like GenerateTimezoneFiles in Install.pm for the MSVC
>> build does not quite do what make install does for src/timezone.
>> Nothing seems to pass the -p parameter as the following is doing:
>
> Ah-hah. Still, the log message should have been there before.
>

No, it didn't exist before because dirname passed to scan_directory_ci
didn't contain the filename appended to it.

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-05-07 15:17:08 Re: pgsql: Improve performance of timezone loading, especially pg_timezone_
Previous Message Amit Kapila 2017-05-07 14:58:27 Re: pgsql: Improve performance of timezone loading, especially pg_timezone_