| From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Improve performance of timezone loading, especially pg_timezone_ |
| Date: | 2017-05-08 01:58:47 |
| Message-ID: | CAKJS1f9uYxUKJW3Ns=YMRxtNE3GWM9+aKDmW+yA0iSG1tLO=Bg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 8 May 2017 at 02:57, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> writes:
>> OK, so it looks like GenerateTimezoneFiles in Install.pm for the MSVC
>> build does not quite do what make install does for src/timezone.
>> Nothing seems to pass the -p parameter as the following is doing:
>
> Ah-hah. Still, the log message should have been there before.
> Maybe just nobody noticed?
Thanks for pushing.
The error messages were not there before. I think just load_ok would
have ended up false in tzparse(). There seems to be code to handle
that without producing any error.
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2017-05-08 07:56:29 | pgsql: Remove poorly worded and duplicated comment |
| Previous Message | Tom Lane | 2017-05-07 20:56:51 | pgsql: Release notes for 9.6.3, 9.5.7, 9.4.12, 9.3.17, 9.2.21. |