Re: pg_verifybackup: TAR format backup verification

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> Here is an attempt at cleaning this up. I'm far from convinced that
> it's fully correct; my local compiler (clang version 15.0.7) doesn't
> seem fussed about conflating size_t with uint64, not even with -Wall
> -Werror. I don't suppose you have a fussier compiler locally that you
> can use to test this?

Sure, I can try it on mamba's host. It's slow though ...

> Respectfully, if you'd just said in your first email about this "I
> understand that you were trying to be consistent with a format string
> somewhere else, but I don't think that's a good reason to do it this
> way, so please use %llu and insert a cast," I would have just said
> "fine, no problem" and I wouldn't have been irritated at all.

I apologize for rubbing you the wrong way on this. It was not my
intent. (But, in fact, I had not realized you copied that code
from somewhere else.)

regards, tom lane