Re: pgsql: Fix memory leak in pgbench

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Fix memory leak in pgbench
Date: 2019-04-11 04:53:58
Message-ID: 12886.1554958438@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> . o O ( Is it time to run with -Werror on some BF animals yet? )

I've got -Werror turned on on longfin; I'm surprised that it's not
whining about this. Perhaps -Wdeclaration-after-statement doesn't
really do anything on clang?

Anyway, I'd be in favor of having at least one reasonably-recent-gcc
animal running with -Werror. gcc and clang seem to have rather
different sets of warnings.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2019-04-11 05:05:19 Re: pgsql: Fix declaration after statement
Previous Message Alvaro Herrera 2019-04-11 03:58:41 Re: pgsql: Fix memory leak in pgbench