| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Fix memory leak in pgbench |
| Date: | 2019-04-11 05:10:16 |
| Message-ID: | CAD21AoCW9qpvT2rmd_QyX+jOsd=8GurLRRKMy7m23WXix4RvUw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Thu, Apr 11, 2019 at 1:54 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> > . o O ( Is it time to run with -Werror on some BF animals yet? )
>
> I've got -Werror turned on on longfin; I'm surprised that it's not
> whining about this. Perhaps -Wdeclaration-after-statement doesn't
> really do anything on clang?
>
> Anyway, I'd be in favor of having at least one reasonably-recent-gcc
> animal running with -Werror. gcc and clang seem to have rather
> different sets of warnings.
+1
FWIW, I've found at least grouse[1] and koreaceratops[2] using gcc
4.4.7 (not recent though) complains this warning.
[1] https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=grouse&dt=2019-04-10%2009%3A06%3A08&stg=make
[2] https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=koreaceratops&dt=2019-04-10%2007%3A59%3A42&stg=make
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2019-04-11 05:11:33 | Re: pgsql: Fix memory leak in pgbench |
| Previous Message | Tom Lane | 2019-04-11 05:05:19 | Re: pgsql: Fix declaration after statement |