| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Fix memory leak in pgbench |
| Date: | 2019-04-11 05:11:33 |
| Message-ID: | CAD21AoCpGSkvMNE7iO_mkWodrV-QpUZDqtAG5bzspp4=QFiTCA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Thu, Apr 11, 2019 at 12:58 PM Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
>
> On 2019-Apr-10, Masahiko Sawada wrote:
>
> > This change leads a compiler warning on my machine:
> >
> > pgbench.c: In function ‘readCommandResponse’:
> > pgbench.c:2730: warning: ISO C90 forbids mixed declarations and code
>
> > I think we should declare is_last before doing next_res = PQgetResult(st->con).
> >
> > Attached patch fixes it.
>
> Thanks, pushed.
>
Thank you!
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2019-04-11 05:19:06 | Re: pgsql: Fix declaration after statement |
| Previous Message | Masahiko Sawada | 2019-04-11 05:10:16 | Re: pgsql: Fix memory leak in pgbench |