Re: pgsql: Fix memory leak in pgbench

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Fix memory leak in pgbench
Date: 2019-04-11 03:58:41
Message-ID: 20190411035841.GA14826@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 2019-Apr-10, Masahiko Sawada wrote:

> This change leads a compiler warning on my machine:
>
> pgbench.c: In function ‘readCommandResponse’:
> pgbench.c:2730: warning: ISO C90 forbids mixed declarations and code

> I think we should declare is_last before doing next_res = PQgetResult(st->con).
>
> Attached patch fixes it.

Thanks, pushed.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2019-04-11 04:53:58 Re: pgsql: Fix memory leak in pgbench
Previous Message Alvaro Herrera 2019-04-11 03:57:12 pgsql: Fix declaration after statement