Re: pgsql: Fix memory leak in pgbench

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Fix memory leak in pgbench
Date: 2019-04-11 07:03:19
Message-ID: alpine.DEB.2.21.1904110848160.17095@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers


Hello Tom,

> Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
>> . o O ( Is it time to run with -Werror on some BF animals yet? )
>
> I've got -Werror turned on on longfin; I'm surprised that it's not
> whining about this. Perhaps -Wdeclaration-after-statement doesn't
> really do anything on clang?
>
> Anyway, I'd be in favor of having at least one reasonably-recent-gcc
> animal running with -Werror. gcc and clang seem to have rather
> different sets of warnings.

Yep. Hopefully non contradictory:-)

I can set up farm animals with bleeding age clang/gcc (compiled weekly
from sources) with -Werror (seawasp & moonjelly are already running with
those but without -Werror).

However, I'm not sure how motivated the project is with keeping up with
the latest warnings, there could be some instability, it may require some
adjustements, but they are a glimpse of what is to come, so maybe a less
bleeding edge set of compilers should be selected.

--
Fabien.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2019-04-11 08:23:48 Re: pgsql: Fix memory leak in pgbench
Previous Message Thomas Munro 2019-04-11 05:19:06 Re: pgsql: Fix declaration after statement