Re: Should we add debug_parallel_query=regress to CI?

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Peter Geoghegan <pg(at)bowt(dot)ie>, Robert Haas <robertmhaas(at)gmail(dot)com>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Should we add debug_parallel_query=regress to CI?
Date: 2025-03-05 18:03:16
Message-ID: zjlzcz6qs7a6zg65hrqrkjhwj5y6cyuvjlmrygaylqe3ltqrxb@xvndetycvuk2
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2025-03-05 12:29:15 -0500, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > I guess we could be add a "standardized" section at the top of each task
> > describing their oddities? Not sure it's worth it.
>
> I think this does need to be documented somewhere/somehow, just so
> that people don't waste time focusing on "it's failing on FreeBSD"
> when the actual cause is some other thing we happened to load
> onto that task.

0002 is a first draft for one way to do this.

Of course this still requires somebody analyzing a failure to look at
cirrus.tasks.yml, but I don't know if we can do a whole lot about that?

I wondered about making the SPECIAL thing an environment variable instead of a
comment, that way it'd probably be visible to cfbot. But I don't really see
what it could do with that information.

I guess we could make the SPECIAL: comments into echos in a
special_script:

that way it would show up as an explicit "section" in the per-task CI
output. But I don't know how much that would help, the failures due to the
tasks specialness could be during build, testing etc, so the "special" section
won't necessarily be close to the failing step.

Greetings,

Andres Freund

Attachment Content-Type Size
v2-0001-ci-freebsd-Specify-debug_parallel_query-regress.patch text/x-diff 1.7 KB
v2-0002-ci-Document-what-makes-certain-tasks-special.patch text/x-diff 3.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2025-03-05 18:10:00 Re: Should we add debug_parallel_query=regress to CI?
Previous Message Robert Haas 2025-03-05 17:57:06 Re: making EXPLAIN extensible