Re: BUG #18362: unaccent rules and Old Greek text

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Robert Haas <robertmhaas(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Cees van Zeeland <cees(dot)van(dot)zeeland(at)freedom(dot)nl>, Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #18362: unaccent rules and Old Greek text
Date: 2024-05-15 06:45:27
Message-ID: fed622f0-b7bb-4294-a91b-02ccdd2bf54f@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On 14.05.24 16:51, Robert Haas wrote:
> 1. The question of rule file load times seems like something that
> anyone who could compile PostgreSQL with and without a patch applied
> could test in under an hour. They could then report the results that
> they got, and people here could judge whether the resulting numbers
> are totally cool or very sad or something in between. Anyone willing
> to do that?

The rules are only loaded once on first use, right? I tested with

date; for x in $(seq 1 1000); do psql -X -c "select unaccent('foobar')"
-o /dev/null; done; date

and this had the same runtime (about 8 seconds here) with and without
the patch.

Btw., with the patch I get

WARNING: duplicate source strings, first one will be used

so it will need to adjustments in how the rules are produced.

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Peter Eisentraut 2024-05-15 07:01:10 Re: BUG #18362: unaccent rules and Old Greek text
Previous Message Bowen Shi 2024-05-15 02:43:32 Re: relfrozenxid may disagree with row XIDs after 1ccc1e05ae