| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Cees van Zeeland <cees(dot)van(dot)zeeland(at)freedom(dot)nl>, Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #18362: unaccent rules and Old Greek text |
| Date: | 2024-05-15 13:40:22 |
| Message-ID: | CA+TgmoZ76RndbHPMm-E0A0cnQXsPOKyThQXX8gVqsLNn_egj9w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Wed, May 15, 2024 at 2:45 AM Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
> On 14.05.24 16:51, Robert Haas wrote:
> > 1. The question of rule file load times seems like something that
> > anyone who could compile PostgreSQL with and without a patch applied
> > could test in under an hour. They could then report the results that
> > they got, and people here could judge whether the resulting numbers
> > are totally cool or very sad or something in between. Anyone willing
> > to do that?
>
> The rules are only loaded once on first use, right? I tested with
>
> date; for x in $(seq 1 1000); do psql -X -c "select unaccent('foobar')"
> -o /dev/null; done; date
>
> and this had the same runtime (about 8 seconds here) with and without
> the patch.
Cool. Sounds like that's not a problem.
> Btw., with the patch I get
>
> WARNING: duplicate source strings, first one will be used
>
> so it will need to adjustments in how the rules are produced.
OK. Does anyone want to look into that?
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2024-05-15 13:41:45 | Re: BUG #18362: unaccent rules and Old Greek text |
| Previous Message | Rémi Cura | 2024-05-15 13:30:59 | Re: BUG #18464: Replacing a SQL function silently drops the generated columns that use this function |