Re: Set AUTOCOMMIT to on in script output by pg_dump

From: Shinya Kato <Shinya11(dot)Kato(at)oss(dot)nttdata(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Treat <rob(at)xzilla(dot)net>, Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Set AUTOCOMMIT to on in script output by pg_dump
Date: 2025-01-22 13:01:48
Message-ID: fde6fde425aa97efa26e27ec7cc841b4@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi, thank you for the reviews.

On 2025-01-18 00:45, Robert Treat wrote:
> This looks pretty good to me. I think there are a couple of minor
> grammar changes that could be made, and I think the pg_dumpall section
> could use a couple tweaks, specifically 1) not all incantations of
> pg_dumpall emit psql meta commands (-g comes to mind quickly) and ISTR
> some non-psql clients honor psql meta commands, so I would lessen the
> language around incompatibility, and 2) I think adding an explicit -f
> for the database name in the pg_dumpall is clearer, and mirrors the
> pg_dump example.

Thanks, I had no reason to oppose it, so I reflected that in the patch.

On 2025-01-18 05:11, Tom Lane wrote:
> Robert Treat <rob(at)xzilla(dot)net> writes:
>> suggested diffs attached, let me know if you would like a consolidated
>> patch
>
> Sadly, the cfbot is now confused since it doesn't understand the idea
> of an incremental patch. Somebody please post a consolidated patch.

I've attached new consolidated patch.

> For myself, I'd suggest writing the examples with -X not --no-psqlrc.
> -X is shorter, it's more likely to be what people would actually
> type, and it's not jarringly inconsistent with the adjacent use
> of -h and other short-form switches. We can write the added
> paragraphs like
>
> It is generally recommended to use the <option>-X</option>
> (<option>--no-psqlrc</option>) option when restoring a database ...
>
> to provide clarity about what the switch does.

I agree to it and fixed the patch.

--
Regards,
Shinya Kato
NTT DATA GROUP CORPORATION

Attachment Content-Type Size
v3-0001-doc-Add-no-psqlrc-in-pg_dump-pg_dumpall-docs.patch text/x-diff 6.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Hunaid Sohail 2025-01-22 13:33:48 Re: [PATCH] Add roman support for to_number function
Previous Message Vitaly Davydov 2025-01-22 12:45:30 Re: An improvement of ProcessTwoPhaseBuffer logic