| From: | Hunaid Sohail <hunaidpgml(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Maciek Sakrejda <m(dot)sakrejda(at)gmail(dot)com>, Tomas Vondra <tomas(at)vondra(dot)me> |
| Subject: | Re: [PATCH] Add roman support for to_number function |
| Date: | 2025-01-22 13:33:48 |
| Message-ID: | CAMWA6yaUufMWn57qNf_WZuA4joREYERKhqjB172i0LDg6dm1TQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
I have attached a new patch v8 with the following changes:
1. Fixed cases reported by Maciek.
2. Handles leading spaces in input string.
I have also added a few more negative tests after Maciek reported
a few cases.
I have also updated the format in the round trip test:
...to_char(i, 'FMRN') ... to
...to_char(i, 'RN') ...
which verifies that leading spaces are now handled in input
string with simple 'RN' when used with to_number.
Looking forward to your feedback.
Regards,
Hunaid Sohail
| Attachment | Content-Type | Size |
|---|---|---|
| v8-0001-Add-roman-support-for-to_number-function.patch | application/octet-stream | 15.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David G. Johnston | 2025-01-22 13:38:34 | Re: [PATCH] Fix a tiny typo in the documentation |
| Previous Message | Shinya Kato | 2025-01-22 13:01:48 | Re: Set AUTOCOMMIT to on in script output by pg_dump |