Re: Set AUTOCOMMIT to on in script output by pg_dump

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Treat <rob(at)xzilla(dot)net>
Cc: Shinya Kato <Shinya11(dot)Kato(at)oss(dot)nttdata(dot)com>, Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Set AUTOCOMMIT to on in script output by pg_dump
Date: 2025-01-17 20:11:10
Message-ID: 2328259.1737144670@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Treat <rob(at)xzilla(dot)net> writes:
> suggested diffs attached, let me know if you would like a consolidated patch

Sadly, the cfbot is now confused since it doesn't understand the idea
of an incremental patch. Somebody please post a consolidated patch.

For myself, I'd suggest writing the examples with -X not --no-psqlrc.
-X is shorter, it's more likely to be what people would actually
type, and it's not jarringly inconsistent with the adjacent use
of -h and other short-form switches. We can write the added
paragraphs like

It is generally recommended to use the <option>-X</option>
(<option>--no-psqlrc</option>) option when restoring a database ...

to provide clarity about what the switch does.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Wolfgang Walther 2025-01-17 20:20:03 Re: Fwd: Re: proposal: schema variables
Previous Message Tom Lane 2025-01-17 19:39:32 Re: [PATCH] Add some documentation on how to call internal functions