| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Cc: | Florents Tselai <florents(dot)tselai(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Add some documentation on how to call internal functions |
| Date: | 2025-01-17 19:39:32 |
| Message-ID: | 2324614.1737142772@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> writes:
> pá 18. 10. 2024 v 22:23 odesílatel Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> napsal:
>> The problem here is that we failed to pass through the result of
>> PG_GET_COLLATION() to text_starts_with. We could do that, certainly,
>> for a couple more lines of code. But it feels like this is getting
>> into details that obscure the main point. I wonder if it'd be better
>> to choose a different example that calls a non-collation-dependent
>> target function.
> This can be a trap for some beginners too. So example of
> DirectFunctionCall2Coll can be nice
Hearing no other comments, I fixed the example to pass through
collation and pushed it.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-01-17 20:11:10 | Re: Set AUTOCOMMIT to on in script output by pg_dump |
| Previous Message | Jacob Champion | 2025-01-17 19:02:15 | Re: [PoC] Federated Authn/z with OAUTHBEARER |