| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: CompilerWarnings task does not catch C++ warnings |
| Date: | 2024-06-18 14:22:49 |
| Message-ID: | f6fcffc6-aded-453f-baab-7beb9e1deb1a@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 18.06.24 16:08, Tom Lane wrote:
> Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
>> The CompilerWarnings task on Cirrus CI does not catch warnings in C++
>> code. It tries to make warnings fatal by passing COPT='-Werror', but
>> that does not apply to C++ compilations.
>> I suggest that we just add COPT to CXXFLAGS as well. I think passing
>> -Werror is just about the only reasonable use of COPT nowadays, so
>> making that more robust seems useful. I don't think there is a need for
>> a separate make variable for C++ here.
>
> +1, but what about the meson side of things?
If you use meson {setup|configure} --werror, that would affect both C
and C++ compilers.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Sharma | 2024-06-18 14:28:26 | Re: Truncation of mapped catalogs (whether local or shared) leads to server crash |
| Previous Message | Peter Eisentraut | 2024-06-18 14:22:01 | Re: may be a buffer overflow problem |