Re: CompilerWarnings task does not catch C++ warnings

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: CompilerWarnings task does not catch C++ warnings
Date: 2024-06-18 14:08:11
Message-ID: 3595843.1718719691@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
> The CompilerWarnings task on Cirrus CI does not catch warnings in C++
> code. It tries to make warnings fatal by passing COPT='-Werror', but
> that does not apply to C++ compilations.
> I suggest that we just add COPT to CXXFLAGS as well. I think passing
> -Werror is just about the only reasonable use of COPT nowadays, so
> making that more robust seems useful. I don't think there is a need for
> a separate make variable for C++ here.

+1, but what about the meson side of things?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2024-06-18 14:11:03 Re: may be a buffer overflow problem
Previous Message Dave Page 2024-06-18 13:53:53 Meson far from ready on Windows