| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | CompilerWarnings task does not catch C++ warnings |
| Date: | 2024-06-18 07:27:02 |
| Message-ID: | fe3e200c-edee-44e0-a6e3-d45dca72873b@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
The CompilerWarnings task on Cirrus CI does not catch warnings in C++
code. It tries to make warnings fatal by passing COPT='-Werror', but
that does not apply to C++ compilations.
I suggest that we just add COPT to CXXFLAGS as well. I think passing
-Werror is just about the only reasonable use of COPT nowadays, so
making that more robust seems useful. I don't think there is a need for
a separate make variable for C++ here.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Apply-COPT-to-CXXFLAGS-as-well.patch | text/plain | 663 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sven Klemm | 2024-06-18 07:32:30 | Re: [PATCH] Improve error message when trying to lock virtual tuple. |
| Previous Message | Euler Taveira | 2024-06-18 07:23:52 | Re: speed up a logical replica setup |