| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, vignesh C <vignesh21(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Split xlog.c |
| Date: | 2022-02-14 09:36:37 |
| Message-ID: | ed0002e7-5f03-bebd-1d42-cb371a864474@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 27/01/2022 08:34, Michael Paquier wrote:
> On Tue, Jan 25, 2022 at 12:12:40PM +0200, Heikki Linnakangas wrote:
>> In last round of review, I spotted one bug: I had mixed up the meaning of
>> EndOfLogTLI. It is the TLI in the *filename* of the WAL segment that we read
>> the last record from, which can be different from the TLI that the last
>> record is actually on. All existing tests were passing with that bug, so I
>> added a test case to cover that case.
>
> FYI, this overlaps with a different patch sent recently, as of this
> thread:
> https://www.postgresql.org/message-id/CAAJ_b94Vjt5cXGza_1MkjLQWciNdEemsmiWuQj0d=M7JfjAa1g@mail.gmail.com
Thanks, I pushed this new test case now.
With the rest of the patches, I'm seeing a mysterious failure in cirrus
CI, on macOS on the 027_stream_regress.pl test. It doesn't make much
sense to me, but I'm investigating that now.
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2022-02-14 09:37:57 | Re: TAP test to cover "EndOfLogTLI != replayTLI" case |
| Previous Message | Heikki Linnakangas | 2022-02-14 09:34:10 | pgsql: Add test case for an archive recovery corner case. |