Re: TAP test started using meson, can get a tcp port already used by another test.

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Andres Freund <andres(at)anarazel(dot)de>, Zharkov Roman <r(dot)zharkov(at)postgrespro(dot)ru>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: TAP test started using meson, can get a tcp port already used by another test.
Date: 2025-02-21 16:04:49
Message-ID: eb22ad13-4666-4c51-a98d-5774b34ee1b8@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 2025-02-21 Fr 10:50 AM, Andres Freund wrote:
>
>
>> Can we explicitly set the MESON_BUILD_ROOT environment variable when running
>> a test? With included patch for the src/tools/testwrap file, each instance
>> gets an unique TCP port.
> I don't like that, feels like a "namespace violation" to set a MESON_*
> variable, why not set the top_builddir or a dedicated variable?
>
> And I don't think it should be done in testwrap, but to test_env in the
> top-level meson.build.
>
> Something like the attached?
>

LGTM

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2025-02-21 16:08:11 Re: Redact user password on pg_stat_statements
Previous Message Tom Lane 2025-02-21 15:55:03 Re: generic plans and "initial" pruning