From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
Cc: | Zharkov Roman <r(dot)zharkov(at)postgrespro(dot)ru>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: TAP test started using meson, can get a tcp port already used by another test. |
Date: | 2025-02-21 16:49:22 |
Message-ID: | x5wfegcxje6l2m63sigzgdp246tfuqnrpicbm6nqx6ujgoncyg@kmcqudiw2yfz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On 2025-02-21 11:04:49 -0500, Andrew Dunstan wrote:
> On 2025-02-21 Fr 10:50 AM, Andres Freund wrote:
> > > Can we explicitly set the MESON_BUILD_ROOT environment variable when running
> > > a test? With included patch for the src/tools/testwrap file, each instance
> > > gets an unique TCP port.
> > I don't like that, feels like a "namespace violation" to set a MESON_*
> > variable, why not set the top_builddir or a dedicated variable?
> >
> > And I don't think it should be done in testwrap, but to test_env in the
> > top-level meson.build.
> >
> > Something like the attached?
> >
>
> LGTM
Thanks for the quick review!
For some reason perltidy moves the $ENV{top_builddir} into the line with the =
once there's only one \n||. Somewhat annoying.
Pushed.
And thanks for the report, Roman!
Greetings,
Andres
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2025-02-21 16:57:44 | Re: Redact user password on pg_stat_statements |
Previous Message | Andrew Dunstan | 2025-02-21 16:38:00 | Re: Redact user password on pg_stat_statements |