| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Tomas Vondra <tomas(at)vondra(dot)me>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Should heapam_estimate_rel_size consider fillfactor? |
| Date: | 2025-02-18 12:29:48 |
| Message-ID: | e295128c-13e2-4d4f-a774-e493c9fe52fe@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 18/02/2025 14:01, Tomas Vondra wrote:
> On 2/4/25 17:54, Tomas Vondra wrote:
>> On 2/4/25 16:02, Tomas Vondra wrote:
>>> ...
>>>
>>> Thanks for the report. And yeah, clamping it to 1 seems like the right
>>> fix for this. I wonder if it's worth inventing some sort of test for
>>> this, shouldn't be too hard I guess.
>>>
>>> In any case, I'll take care of the fix/backpatch soon.
>>
>> Here's a proposed fix, including a simple test in the stats suite.
>
> Here's a slightly improved fix, with a proper commit message and
> simplified test case. I plan to push this once the releases get out (I
> know it was stamped already, but ...).
Looks good, thanks!
--
Heikki Linnakangas
Neon (https://neon.tech)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhang Mingli | 2025-02-18 12:43:02 | Re: Proposal to CREATE FOREIGN TABLE LIKE |
| Previous Message | Daniel Gustafsson | 2025-02-18 12:29:27 | Re: Support a wildcard in backtrace_functions |