| From: | Tomas Vondra <tomas(at)vondra(dot)me> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Should heapam_estimate_rel_size consider fillfactor? |
| Date: | 2025-02-18 12:01:55 |
| Message-ID: | ac3735e0-8211-4a7b-a96c-912f80698a5e@vondra.me |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2/4/25 17:54, Tomas Vondra wrote:
> On 2/4/25 16:02, Tomas Vondra wrote:
>> ...
>>
>> Thanks for the report. And yeah, clamping it to 1 seems like the right
>> fix for this. I wonder if it's worth inventing some sort of test for
>> this, shouldn't be too hard I guess.
>>
>> In any case, I'll take care of the fix/backpatch soon.
>>
>
> Here's a proposed fix, including a simple test in the stats suite.
>
Here's a slightly improved fix, with a proper commit message and
simplified test case. I plan to push this once the releases get out (I
know it was stamped already, but ...).
regards
--
Tomas Vondra
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Correct-relation-size-estimate-with-low-fillfactor.patch | text/x-patch | 3.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhang Mingli | 2025-02-18 12:07:18 | Re: Proposal to CREATE FOREIGN TABLE LIKE |
| Previous Message | Andy Fan | 2025-02-18 11:48:30 | Why does exec_simple_query requires 2 snapshots |