| From: | Tomas Vondra <tomas(at)vondra(dot)me> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Should heapam_estimate_rel_size consider fillfactor? |
| Date: | 2025-02-04 16:54:06 |
| Message-ID: | 9cf07d7e-a1e0-48f0-864b-1c9a12a2e7b6@vondra.me |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2/4/25 16:02, Tomas Vondra wrote:
> ...
>
> Thanks for the report. And yeah, clamping it to 1 seems like the right
> fix for this. I wonder if it's worth inventing some sort of test for
> this, shouldn't be too hard I guess.
>
> In any case, I'll take care of the fix/backpatch soon.
>
Here's a proposed fix, including a simple test in the stats suite.
regards
--
Tomas Vondra
| Attachment | Content-Type | Size |
|---|---|---|
| fillfactor-fix.patch | text/x-patch | 3.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-02-04 16:59:43 | Re: Add a warning message when using unencrypted passwords |
| Previous Message | Daniel Gustafsson | 2025-02-04 16:51:28 | Re: add missing PQfinish() calls to vacuumdb |