| From: | Tomas Vondra <tomas(at)vondra(dot)me> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Should heapam_estimate_rel_size consider fillfactor? |
| Date: | 2025-02-19 22:56:02 |
| Message-ID: | 66458313-f991-4c64-8440-d26aa6cbe231@vondra.me |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2/18/25 13:29, Heikki Linnakangas wrote:
> On 18/02/2025 14:01, Tomas Vondra wrote:
>> On 2/4/25 17:54, Tomas Vondra wrote:
>>> On 2/4/25 16:02, Tomas Vondra wrote:
>>>> ...
>>>>
>>>> Thanks for the report. And yeah, clamping it to 1 seems like the right
>>>> fix for this. I wonder if it's worth inventing some sort of test for
>>>> this, shouldn't be too hard I guess.
>>>>
>>>> In any case, I'll take care of the fix/backpatch soon.
>>>
>>> Here's a proposed fix, including a simple test in the stats suite.
>>
>> Here's a slightly improved fix, with a proper commit message and
>> simplified test case. I plan to push this once the releases get out (I
>> know it was stamped already, but ...).
>
> Looks good, thanks!
>
Pushed. Thanks!
--
Tomas Vondra
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ilia Evdokimov | 2025-02-19 22:59:02 | Re: Sample rate added to pg_stat_statements |
| Previous Message | Daniel Gustafsson | 2025-02-19 22:55:05 | Re: new commitfest transition guidance |