| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | jian he <jian(dot)universality(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, Stephen Frost <sfrost(at)snowman(dot)net>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, alvherre(at)alvh(dot)no-ip(dot)org |
| Subject: | Re: Statistics Import and Export |
| Date: | 2025-02-11 01:21:39 |
| Message-ID: | e048dd2e1e6afe55a2521f853e8346f39473ec7d.camel@j-davis.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, 2025-02-09 at 22:00 -0500, Corey Huinker wrote:
>
> 0002 - I've done some documentation rewording, mostly wording changes
> where behaviors surrounding data-only dumps are actually meant for
> any dump that has all schema excluded.
Comments on v45-0002:
* Why is generate_old_dump() passing optionally passing --no-statistics
to pg_dumpall along with --globals-only? If --globals-only is
specified, no stats are dumped anyway, right?
* The tag is still wrong: it is "STATISTICS DATA mytable" when it
should just be "mytable".
* What's the logic behind the pg_dumpall options? The docs say
it should support the new pg_dump options, but they don't seem to work.
* The enum entryType casing is unconventional. How about a type name of
TocEntryType and values like STATS_TOC_ENTRY.
* The pg_dump test suite time has increased by ~50%. If some tests are
superfluous, please remove them.
Regards,
Jeff Davis
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Japin Li | 2025-02-11 01:25:04 | Re: [RFC] Lock-free XLog Reservation from WAL |
| Previous Message | Andres Freund | 2025-02-11 01:06:12 | Re: Eagerly scan all-visible pages to amortize aggressive vacuum |