Re: Statistics Import and Export

>
>
>
> Comments on v45-0002:
>

Assuming you meant 47

>
> * Why is generate_old_dump() passing optionally passing --no-statistics
> to pg_dumpall along with --globals-only? If --globals-only is
> specified, no stats are dumped anyway, right?
>

Removed.

>
> * The tag is still wrong: it is "STATISTICS DATA mytable" when it
> should just be "mytable".
>

Fixed.

>
> * What's the logic behind the pg_dumpall options? The docs say
> it should support the new pg_dump options, but they don't seem to work.
>

Fixed.

>
> * The enum entryType casing is unconventional. How about a type name of
> TocEntryType and values like STATS_TOC_ENTRY.
>

Conventionified.

>
> * The pg_dump test suite time has increased by ~50%. If some tests are
> superfluous, please remove them.

The nature of the TAP tests is that every new check N must be run against
every existing dump run M adding one N check gets you M scans, and adding a
dump type requires that it be scanned N times, and we increased both N and
M. If there were a way to only do stats-related tests against a subset of
the dumps, then yes, we could trim it down, but as it is I think it's a
limitation of the testing structure. But aside from creating a whole extra
XYZ_pg_dump.pl file, I don't think there's a way to do that.

The previous 0001 is now committed (thanks!) so only one remains.