Re: Statistics Import and Export

From: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Jeff Davis <pgsql(at)j-davis(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, Stephen Frost <sfrost(at)snowman(dot)net>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, alvherre(at)alvh(dot)no-ip(dot)org
Subject: Re: Statistics Import and Export
Date: 2025-02-10 03:00:18
Message-ID: CADkLM=fzX7QX6r78fShWDjNN3Vcr4PVAnvXxQ4DiGy6V=0bCUA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>
>
> I would recommend to work a bit more the tests by updating the stats
> of a relation with the SQL functions in a transaction and add some
> queries on pg_locks for locktype = 'relation' that are able to check
> the locks we are taking when running these operations (return pairs of
> relation::regclass and mode, for example). Doing that for
> non-partitioned relations is also something I would do, so as the
> locking schema we are using is clearly tracked and that future
> manipulations of the area would help one in tracking problems. Bonus
> points: scans of pg_locks are cheap tests.
> --
> Michael
>

0001 - I've added pg_locks tests for a regular index and a partitioned
index.

0002 - I've done some documentation rewording, mostly wording changes where
behaviors surrounding data-only dumps are actually meant for any dump that
has all schema excluded.

Attachment Content-Type Size
v47-0001-Lock-table-first-when-setting-index-relation-sta.patch text/x-patch 10.4 KB
v47-0002-Enable-dumping-of-table-index-stats-in-pg_dump.patch text/x-patch 69.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message wenhui qiu 2025-02-10 03:39:14 Uncached buffered IO
Previous Message Peter Smith 2025-02-10 01:35:06 Re: Enhance 'pg_createsubscriber' to retrieve databases automatically when no database is provided.