Re: Inconsistent printf placeholders

On 14.03.24 05:20, Kyotaro Horiguchi wrote:
> A recent commit 6612185883 introduced two error messages that are
> identical in text but differ in their placeholders.
>
> - pg_fatal("could not read file \"%s\": read only %d of %d bytes",
> - filename, (int) rb, (int) st.st_size);
> + pg_fatal("could not read file \"%s\": read only %zd of %lld bytes",
> + filename, rb, (long long int) st.st_size);
> ...
> - pg_fatal("could not read file \"%s\": read only %d of %d bytes",
> + pg_fatal("could not read file \"%s\": read only %d of %u bytes",
> rf->filename, rb, length);
>
> I'd be happy if the two messages kept consistency. I suggest aligning
> types instead of making the messages different, as attached.

If you want to make them uniform, then I suggest the error messages
should both be "%zd of %zu bytes", which are the actual types read()
deals with.