From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
---|---|
To: | peter(at)eisentraut(dot)org |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Inconsistent printf placeholders |
Date: | 2024-03-15 02:27:26 |
Message-ID: | 20240315.112726.1142170841285161657.horikyota.ntt@gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Thank you for the suggestions.
At Thu, 14 Mar 2024 13:45:41 +0100, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote in
> I've only skimmed this so far but +1 on keeping the messages the same where
> possible to reduce translation work. Adding a comment on the message where the
> casting is done to indicate that it is for translation might reduce the risk of
> it "getting fixed" down the line.
Added a comment "/* cast xxx to avoid extra translatable messages */.
At Thu, 14 Mar 2024 14:02:46 +0100, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote in
> If you want to make them uniform, then I suggest the error messages
Yeah. Having the same messages with only the placeholders changed is
not very pleasing during translation. If possible, I would like to
align them.
> should both be "%zd of %zu bytes", which are the actual types read()
> deals with.
I have considered only the two messages. Actually, buffile.c and md.c
are already like that. The attached aligns the messages in
pg_combinebackup.c and reconstruct.c with the precedents.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
Attachment | Content-Type | Size |
---|---|---|
unify_read_err_msg_v2.patch | text/x-patch | 1.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Kyotaro Horiguchi | 2024-03-15 02:28:12 | Re: Typos in reorderbuffer.c. |
Previous Message | David Rowley | 2024-03-15 02:21:02 | Re: Add bump memory context type and use it for tuplesorts |