From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
---|---|
To: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Inconsistent printf placeholders |
Date: | 2024-03-14 04:20:41 |
Message-ID: | 20240314.132041.2150305296896280760.horikyota.ntt@gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hello.
A recent commit 6612185883 introduced two error messages that are
identical in text but differ in their placeholders.
- pg_fatal("could not read file \"%s\": read only %d of %d bytes",
- filename, (int) rb, (int) st.st_size);
+ pg_fatal("could not read file \"%s\": read only %zd of %lld bytes",
+ filename, rb, (long long int) st.st_size);
...
- pg_fatal("could not read file \"%s\": read only %d of %d bytes",
+ pg_fatal("could not read file \"%s\": read only %d of %u bytes",
rf->filename, rb, length);
I'd be happy if the two messages kept consistency. I suggest aligning
types instead of making the messages different, as attached.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
Attachment | Content-Type | Size |
---|---|---|
unify_read_err_msg.patch | text/x-patch | 789 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Kyotaro Horiguchi | 2024-03-14 04:28:17 | Typos in reorderbuffer.c. |
Previous Message | Thomas Munro | 2024-03-14 03:16:24 | Re: Recent 027_streaming_regress.pl hangs |