| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Inconsistent printf placeholders |
| Date: | 2024-03-14 12:45:41 |
| Message-ID: | 3F7ECE6B-B9E8-4E7D-A3DF-C20F5433C4B2@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 14 Mar 2024, at 05:20, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote:
> I'd be happy if the two messages kept consistency. I suggest aligning
> types instead of making the messages different, as attached.
I've only skimmed this so far but +1 on keeping the messages the same where
possible to reduce translation work. Adding a comment on the message where the
casting is done to indicate that it is for translation might reduce the risk of
it "getting fixed" down the line.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2024-03-14 12:45:59 | Re: Flushing large data immediately in pqcomm |
| Previous Message | Robert Haas | 2024-03-14 12:34:37 | Re: BitmapHeapScan streaming read user and prelim refactoring |