Re: Unmark gen_random_uuid() function leakproof

From: Andres Freund <andres(at)anarazel(dot)de>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Unmark gen_random_uuid() function leakproof
Date: 2024-12-09 22:23:25
Message-ID: bwavjkortw4uhac3sp5w5r5fkyn3p6el7esxmxiadlm2qhrdih@3ql4v5r4l2zp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2024-12-09 14:10:30 -0800, Masahiko Sawada wrote:
> While reviewing UUIDv7 patch[1], I realized gen_random_uuid() is
> marked leakproof even though it doesn't take arguments. The functions
> without arguments don't need to be marked leakproof in principle. This
> is the sole function that has no arguments and is listed in the "List
> of built-in leakproof functions" in opr_sanity.sql. I've attached the
> patch for fixing it and for better consistency with new UUID
> generation functions discussed on that thread.

Seems like it'd make sense to add a test to opr_sanity.sql so we don't
reintroduce such cases?

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David G. Johnston 2024-12-09 22:27:02 Re: Document NULL
Previous Message Masahiko Sawada 2024-12-09 22:10:46 Re: Fix tiny memory leaks