Re: Unmark gen_random_uuid() function leakproof

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Unmark gen_random_uuid() function leakproof
Date: 2024-12-09 22:48:51
Message-ID: CAD21AoD7x=1at1tQc=d+HLWPqESUwkJO8QzQLA-dz4ssm4ZjRw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Dec 9, 2024 at 2:23 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> Hi,
>
> On 2024-12-09 14:10:30 -0800, Masahiko Sawada wrote:
> > While reviewing UUIDv7 patch[1], I realized gen_random_uuid() is
> > marked leakproof even though it doesn't take arguments. The functions
> > without arguments don't need to be marked leakproof in principle. This
> > is the sole function that has no arguments and is listed in the "List
> > of built-in leakproof functions" in opr_sanity.sql. I've attached the
> > patch for fixing it and for better consistency with new UUID
> > generation functions discussed on that thread.
>
> Seems like it'd make sense to add a test to opr_sanity.sql so we don't
> reintroduce such cases?
>

Thank you for the comment. It's a good idea. I've updated the patch.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

Attachment Content-Type Size
v2-0001-Unmark-gen_random_uuid-function-leakproof.patch application/octet-stream 3.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Harris 2024-12-09 23:00:43 Re: FileFallocate misbehaving on XFS
Previous Message Tomas Vondra 2024-12-09 22:39:03 Re: psql: Add tab completion for ALTER USER RESET