Re: Fix tiny memory leaks

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Tofig Aliev <t(dot)aliev(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fix tiny memory leaks
Date: 2024-12-09 22:10:46
Message-ID: CAD21AoDYY3w=-Nfc2b-p48Bbs-keE7wRpCYe8MEOKb_gnaV1Wg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Dec 9, 2024 at 12:04 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> > On 9 Dec 2024, at 20:03, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> >
> >> On 9 Dec 2024, at 19:52, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> >>
> >> On Fri, Dec 6, 2024 at 12:49 AM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> >>>
> >>>> On 6 Dec 2024, at 09:38, Tofig Aliev <t(dot)aliev(at)postgrespro(dot)ru> wrote:
> >>>
> >>>> There is a memory leak in functions check_application_name() and check_cluster_name().
> >>>> Functions are located in src/backend/commands/variable.c
> >>>
> >>> LGTM.
> >>
> >> LGTM. It seems commit a9d58bfe8a3a missed to fix this memory leak.
> >
> > Yeah. While fairly insignificant in nature, and there has been no complaints
> > until now, I'm preparing a backpatch down to REL_15_STABLE to keep the code in
> > sync for other backpatches to apply clean.
>
> Done, but to 16 and not 15 which was a typo in the above email.

Thank you!

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2024-12-09 22:23:25 Re: Unmark gen_random_uuid() function leakproof
Previous Message Masahiko Sawada 2024-12-09 22:10:30 Unmark gen_random_uuid() function leakproof