| From: | Tomas Vondra <tomas(at)vondra(dot)me> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Michael Banck <mbanck(at)gmx(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Changing the state of data checksums in a running cluster |
| Date: | 2025-03-10 09:46:32 |
| Message-ID: | b16389e7-fc48-4cb1-a571-ba267bcc375c@vondra.me |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 3/10/25 01:18, Tomas Vondra wrote:
>
> ...
>
> There's still a failure on windows, though. I'd bet that's due to the
> data_checksum/LocalDatachecksumVersion sync not working correctly on
> builds with EXEC_BACKEND, or something like that, but it's too late so
> I'll take a closer look tomorrow.
>
Just like I suspected, there was a bug in EXEC_BACKEND, although a bit
different from what I guessed - the worker state in shmem was zeroed
every time, not just once. And a second issue was child_process_kinds
got out of sync with BackendType (mea culpa).
For me, this passes all CI tests, hopefully cfbot will be happy too.
regards
--
Tomas Vondra
| Attachment | Content-Type | Size |
|---|---|---|
| v20250310c-0001-Online-enabling-and-disabling-of-data-che.patch | text/x-patch | 137.3 KB |
| v20250310c-0002-simple-post-rebase-fixes.patch | text/x-patch | 6.1 KB |
| v20250310c-0003-sync-the-data_checksums-GUC-with-the-loca.patch | text/x-patch | 5.0 KB |
| v20250310c-0004-make-progress-reporting-work.patch | text/x-patch | 12.7 KB |
| v20250310c-0005-update-docs.patch | text/x-patch | 8.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2025-03-10 09:49:15 | Re: 64 bit numbers vs format strings |
| Previous Message | Amul Sul | 2025-03-10 09:42:33 | Re: NOT ENFORCED constraint feature |