| From: | Tomas Vondra <tomas(at)vondra(dot)me> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Michael Banck <mbanck(at)gmx(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Changing the state of data checksums in a running cluster |
| Date: | 2025-03-10 00:18:23 |
| Message-ID: | dbadb903-49f7-470b-95ab-e02986189f3a@vondra.me |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 3/10/25 00:35, Tomas Vondra wrote:
> Seems cfbot was unhappy with the patches, so here's an improved version,
> fixing some minor issues in expected output and a compiler warning.
>
> There however seems to be some issue with 003_standby_restarts, which
> causes failures on freebsd and macos. I don't know what that is about,
> but the test runs much longer than on debian.
>
OK, turns out the failures were caused by the test creating a standby
from a backup, without a slot, so sometimes the primary removed the
necessary WAL. Fixed in the attached version.
There's still a failure on windows, though. I'd bet that's due to the
data_checksum/LocalDatachecksumVersion sync not working correctly on
builds with EXEC_BACKEND, or something like that, but it's too late so
I'll take a closer look tomorrow.
regards
--
Tomas Vondra
| Attachment | Content-Type | Size |
|---|---|---|
| v20250310b-0001-Online-enabling-and-disabling-of-data-che.patch | text/x-patch | 137.3 KB |
| v20250310b-0002-simple-post-rebase-fixes.patch | text/x-patch | 4.3 KB |
| v20250310b-0003-sync-the-data_checksums-GUC-with-the-loca.patch | text/x-patch | 5.0 KB |
| v20250310b-0004-make-progress-reporting-work.patch | text/x-patch | 12.7 KB |
| v20250310b-0005-update-docs.patch | text/x-patch | 8.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2025-03-10 00:23:50 | Re: [BUG]: the walsender does not update its IO statistics until it exits |
| Previous Message | David Rowley | 2025-03-10 00:14:49 | Re: Printing window function OVER clauses in EXPLAIN |