Re: Changing the state of data checksums in a running cluster

From: Tomas Vondra <tomas(at)vondra(dot)me>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, Michael Banck <mbanck(at)gmx(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Changing the state of data checksums in a running cluster
Date: 2025-03-10 11:17:58
Message-ID: 49f6df22-7a40-4ce1-a651-111ac033b2bb@vondra.me
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 3/10/25 10:46, Tomas Vondra wrote:
> On 3/10/25 01:18, Tomas Vondra wrote:
>>
>> ...
>>
>> There's still a failure on windows, though. I'd bet that's due to the
>> data_checksum/LocalDatachecksumVersion sync not working correctly on
>> builds with EXEC_BACKEND, or something like that, but it's too late so
>> I'll take a closer look tomorrow.
>>
>
> Just like I suspected, there was a bug in EXEC_BACKEND, although a bit
> different from what I guessed - the worker state in shmem was zeroed
> every time, not just once. And a second issue was child_process_kinds
> got out of sync with BackendType (mea culpa).
>
> For me, this passes all CI tests, hopefully cfbot will be happy too.
>

A bit embarrassing, I did not notice updating child_process_kinds breaks
the stats regression test, so here's a version fixing that.

regards

--
Tomas Vondra

Attachment Content-Type Size
v20250310d-0001-Online-enabling-and-disabling-of-data-che.patch text/x-patch 137.3 KB
v20250310d-0002-simple-post-rebase-fixes.patch text/x-patch 7.5 KB
v20250310d-0003-sync-the-data_checksums-GUC-with-the-loca.patch text/x-patch 5.0 KB
v20250310d-0004-make-progress-reporting-work.patch text/x-patch 12.7 KB
v20250310d-0005-update-docs.patch text/x-patch 8.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Rushabh Lathia 2025-03-10 11:26:14 Re: Support NOT VALID / VALIDATE constraint options for named NOT NULL constraints
Previous Message Álvaro Herrera 2025-03-10 11:12:33 Re: pgsql: reindexdb: Add the index-level REINDEX with multiple jobs