Re: Translations Fix #1

From: Jonas Thelemann <e-mail(at)jonas-thelemann(dot)de>
To: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Translations Fix #1
Date: 2017-03-20 20:59:17
Message-ID: ae6e5feb-ecf4-b47b-0af4-d37e2b0acc58@jonas-thelemann.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

> I'm not clear why you believe this to be the correct formatting?
Sorry, the link got removed. Here it is written out:
http://english.stackexchange.com/questions/91653/space-before-three-dots
Again, I thought this would simplify the translation process which it
didn't. Either way I googled that and found the stackexchange link above ^^

Would it be an alternative to exclude this kind of punctuation from the
translatable strings? Like /label: '{{ _('Cast') }}///.../'/ (or
similar) for example?/
/

> You might want to discuss any non-trivial fixes here first
> before doing lots of work, just to make sure we're all in agreement
> before you spend significant amounts of time on anything.
Yes, I (will) definitly do that. This idea was just a simple suggestion,
nothing that impactful or important, if you ask me :)

Am 20.03.2017 um 11:51 schrieb Dave Page:
> Hi
>
> On Fri, Mar 17, 2017 at 10:12 PM, Jonas Thelemann
> <e-mail(at)jonas-thelemann(dot)de> wrote:
>> Hello pgAdmin hackers,
>>
>> this is my first suggestion for some translation improvements. It adds a
>> space in front of all occurences of three dots at the end of a string which
>> seems to be the correct language style. Initially I hoped that this would
>> remove doubled strings like "Database" and "Database...", but it didn't.
>> Either way, here is my patch dot.diff.
> I'm not clear why you believe this to be the correct formatting? As
> far as I'm aware in English there wouldn't normally be a space - and
> looking at Google Chrome, PyCharms and various Microsoft and Apple
> apps, none of them seem to have a space before the '...'.
>
>> There are going to be some other fixes that'll improve the application's
>> messages.
> Cool. You might want to discuss any non-trivial fixes here first
> before doing lots of work, just to make sure we're all in agreement
> before you spend significant amounts of time on anything.
>
> Thanks, Dave.
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2017-03-21 05:47:49 pgAdmin 4 commit: Resolved a typo - show a '?' after the 'Show timing'
Previous Message Atira Odhner 2017-03-20 20:17:21 Re: Feature test regression failures