Re: Translations Fix #1

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Jonas Thelemann <e-mail(at)jonas-thelemann(dot)de>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Translations Fix #1
Date: 2017-03-21 09:12:29
Message-ID: CA+OCxoyFQCkh0tUOJWHFyqRKQ=V2JeqXWWuA9WWvZT7QcrK8aQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Mon, Mar 20, 2017 at 8:59 PM, Jonas Thelemann
<e-mail(at)jonas-thelemann(dot)de> wrote:
> I'm not clear why you believe this to be the correct formatting?
>
> Sorry, the link got removed. Here it is written out:
> http://english.stackexchange.com/questions/91653/space-before-three-dots
> Again, I thought this would simplify the translation process which it
> didn't. Either way I googled that and found the stackexchange link above ^^
>
> Would it be an alternative to exclude this kind of punctuation from the
> translatable strings? Like label: '{{ _('Cast') }} ...' (or similar) for
> example?

I don't see any reason that wouldn't work, unless it doesn't make
sense or follow convention in (for example) Japanese or Chinese.

> You might want to discuss any non-trivial fixes here first
> before doing lots of work, just to make sure we're all in agreement
> before you spend significant amounts of time on anything.
>
> Yes, I (will) definitly do that. This idea was just a simple suggestion,
> nothing that impactful or important, if you ask me :)

No, but it must have taken some of your time to create the patch, and
I'd prefer to avoid wasting that if it means you can work on something
of more value :-)

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2017-03-21 10:11:22 pgAdmin 4 commit: Ignore the Yarn lock file.
Previous Message Ashesh Vashi 2017-03-21 05:47:49 pgAdmin 4 commit: Resolved a typo - show a '?' after the 'Show timing'