From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Jonas Thelemann <e-mail(at)jonas-thelemann(dot)de> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Translations Fix #1 |
Date: | 2017-03-20 10:51:00 |
Message-ID: | CA+OCxoxn-4XZ2ZcUSr3hHxyjNp1Rv3odkjN=SSiTvot1ia_5fw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi
On Fri, Mar 17, 2017 at 10:12 PM, Jonas Thelemann
<e-mail(at)jonas-thelemann(dot)de> wrote:
> Hello pgAdmin hackers,
>
> this is my first suggestion for some translation improvements. It adds a
> space in front of all occurences of three dots at the end of a string which
> seems to be the correct language style. Initially I hoped that this would
> remove doubled strings like "Database" and "Database...", but it didn't.
> Either way, here is my patch dot.diff.
I'm not clear why you believe this to be the correct formatting? As
far as I'm aware in English there wouldn't normally be a space - and
looking at Google Chrome, PyCharms and various Microsoft and Apple
apps, none of them seem to have a space before the '...'.
> There are going to be some other fixes that'll improve the application's
> messages.
Cool. You might want to discuss any non-trivial fixes here first
before doing lots of work, just to make sure we're all in agreement
before you spend significant amounts of time on anything.
Thanks, Dave.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2017-03-20 11:12:20 | Re: Patch submissions |
Previous Message | Dave Page | 2017-03-20 10:44:43 | Re: Last few steps for pgadmin4 on RHEL 6 |