| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: macOS prefetching support |
| Date: | 2024-08-28 06:21:04 |
| Message-ID: | ad1f8149-1fc3-417e-a7db-6cf718a2c14b@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 26.08.24 07:54, Thomas Munro wrote:
> On Sat, Aug 24, 2024 at 12:28 AM Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>> In terms of $subject, this patch seems sufficient for now.
>
> WFM. I noticed you don't have an EINTR retry loop, but the man page
> doesn't say you need one, so overall this patch LGTM.
>
> + * posix_fadvise() is the simplest standardized interface that accomplishes
> + * this. We could add an implementation using libaio in the future; but note
> + * that this API is inappropriate for libaio, which wants to have a buffer
> + * provided to read into.
>
> I would consider just dropping that comment about libaio, if touching
> this paragraph. Proposals exist for AIO of course, but not with
> libaio, and better predictions with useful discussion of the topic
> seem unlikely to fit in this margin.
committed with that change
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2024-08-28 06:54:27 | Re: Conflict detection and logging in logical replication |
| Previous Message | Maxim Orlov | 2024-08-28 06:14:35 | Re: Test 041_checkpoint_at_promote.pl faild in installcheck due to missing injection_points |