| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: macOS prefetching support |
| Date: | 2024-08-26 05:54:26 |
| Message-ID: | CA+hUKGKcpRTbiay8ChLFyzq=4qbobTcb_=9P3cxQ+gyS-+pjCA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Aug 24, 2024 at 12:28 AM Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
> In terms of $subject, this patch seems sufficient for now.
WFM. I noticed you don't have an EINTR retry loop, but the man page
doesn't say you need one, so overall this patch LGTM.
+ * posix_fadvise() is the simplest standardized interface that accomplishes
+ * this. We could add an implementation using libaio in the future; but note
+ * that this API is inappropriate for libaio, which wants to have a buffer
+ * provided to read into.
I would consider just dropping that comment about libaio, if touching
this paragraph. Proposals exist for AIO of course, but not with
libaio, and better predictions with useful discussion of the topic
seem unlikely to fit in this margin.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2024-08-26 06:09:19 | Support POSITION with nondeterministic collations |
| Previous Message | Bharath Rupireddy | 2024-08-26 05:39:28 | Re: Introduce new multi insert Table AM and improve performance of various SQL commands with it for Heap AM |