Re: pgindent fails with perl 5.40

From: Erik Wienhold <ewie(at)ewie(dot)name>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: pgindent fails with perl 5.40
Date: 2024-10-08 01:50:09
Message-ID: acd151f0-4548-4ff9-a58e-99f5616dbe22@ewie.name
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I wrote:
> I get this error when running pgindent with perl 5.40:
>
> Attempt to call undefined import method with arguments ("devnull") via package "File::Spec" (Perhaps you forgot to load the package?) at src/tools/pgindent/pgindent line 10.
> BEGIN failed--compilation aborted at src/tools/pgindent/pgindent line 10.
>
> It definitely worked with perl 5.38 before. Not sure if something's
> wrong on my side.

Ah, it's intentional:
https://metacpan.org/release/HAARG/perl-5.40.0/view/pod/perldelta.pod#Calling-the-import-method-of-an-unknown-package-produces-a-warning

> Calling the import method of an unknown package produces a warning
> [...]
> It will also detect cases where a user passes an argument when using a
> package that does not provide its own import
> [...]

Because we use fatal warnings, pgindent fails.

--
Erik

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2024-10-08 01:50:20 Re: Improve EXPLAIN output for multicolumn B-Tree Index
Previous Message Michael Paquier 2024-10-08 01:48:49 Re: [PATCH] pg_permissions