| From: | Frédéric Yhuel <frederic(dot)yhuel(at)dalibo(dot)com> |
|---|---|
| To: | Sami Imseih <samimseih(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Benoit Lobréau <benoit(dot)lobreau(at)dalibo(dot)com>, Guillaume Lelarge <guillaume(dot)lelarge(at)dalibo(dot)com>, Pierrick Chovelon <pierrick(dot)chovelon(at)dalibo(dot)com> |
| Subject: | Re: [BUG] temporary file usage report with extended protocol and unnamed portals |
| Date: | 2025-04-23 09:27:05 |
| Message-ID: | a946ce74-820b-45ec-a9b6-611e8adb3a0b@dalibo.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 4/23/25 09:41, Frédéric Yhuel wrote:
>
>
> On 4/22/25 19:37, Sami Imseih wrote:
>> the patch relies on looking up queryDesc->sourceText inside DropPortal,
>> which Tom raised concerns about earlier in the thread [0]
>
> Yes, I think I had misunderstood what Tom said. Thank you for pointing
> that out.
>
> However, is it really unsafe?
>
> In exec_bind_message, the portal's query string comes from a duplicate
> of the original string (see CreateCachedPlan). So we are safe in this case.
>
> In exec_simple_query, the portal is dropped towards the end of this
> function, so we are safe here too.
>
> Am I missing something?
Note: the patch doesn't work well with server-side prepared statements:
the PREPARE query is blamed instead of the EXECUTE one. But this is
maybe something that can be fixed easily.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2025-04-23 09:35:15 | Re: jsonapi: scary new warnings with LTO enabled |
| Previous Message | Devrim Gündüz | 2025-04-23 09:13:38 | Re: What's our minimum supported Python version? |