| From: | Frédéric Yhuel <frederic(dot)yhuel(at)dalibo(dot)com> |
|---|---|
| To: | Sami Imseih <samimseih(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Benoit Lobréau <benoit(dot)lobreau(at)dalibo(dot)com>, Guillaume Lelarge <guillaume(dot)lelarge(at)dalibo(dot)com>, Pierrick Chovelon <pierrick(dot)chovelon(at)dalibo(dot)com> |
| Subject: | Re: [BUG] temporary file usage report with extended protocol and unnamed portals |
| Date: | 2025-04-23 07:41:58 |
| Message-ID: | f40c6ac6-1358-4a59-bfd4-ebb7427e7497@dalibo.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 4/22/25 19:37, Sami Imseih wrote:
> the patch relies on looking up queryDesc->sourceText inside DropPortal,
> which Tom raised concerns about earlier in the thread [0]
Yes, I think I had misunderstood what Tom said. Thank you for pointing
that out.
However, is it really unsafe?
In exec_bind_message, the portal's query string comes from a duplicate
of the original string (see CreateCachedPlan). So we are safe in this case.
In exec_simple_query, the portal is dropped towards the end of this
function, so we are safe here too.
Am I missing something?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bertrand Drouvot | 2025-04-23 08:01:40 | Avoid core dump in pgstat_read_statsfile() |
| Previous Message | Michael Paquier | 2025-04-23 07:13:14 | Re: Add Pipelining support in psql |